Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Simplify release announces #2419

Merged

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Dec 27, 2022

Add a new workflow to send message on twitter & discord, after a new release is published.

Closes #2341

See the tests done with https://github.com/marketplace/actions/actions-status-discord & https://github.com/marketplace/actions/tweet-action on process-analytics/github-actions-playground#212.

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Dec 27, 2022
@csouchet csouchet force-pushed the 2341-Add_a_workflow_to_announce_a_new_release_from_a_template branch from 043ed32 to 65c948f Compare December 27, 2022 13:54
@csouchet csouchet marked this pull request as ready for review December 27, 2022 13:54
@tbouffard tbouffard changed the title [FEAT] Add a new workflow to send message on twitter & discord, after release [INFRA] Simplify release announces Dec 28, 2022
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ secrets configuration
✔️ tests in the playground
ℹ️ I suggest renaming of some elements of the workflow
❌ the documentation of the release process must be updated

.github/workflows/announce-new-release.yml Outdated Show resolved Hide resolved
.github/workflows/announce-new-release.yml Outdated Show resolved Hide resolved
.github/workflows/announce-new-release.yml Outdated Show resolved Hide resolved
@csouchet csouchet force-pushed the 2341-Add_a_workflow_to_announce_a_new_release_from_a_template branch from 9f1203d to 99dbbd0 Compare December 29, 2022 09:53
@csouchet csouchet force-pushed the 2341-Add_a_workflow_to_announce_a_new_release_from_a_template branch from 99dbbd0 to b543f84 Compare December 29, 2022 09:54
.github/workflows/announce-new-release.yml Outdated Show resolved Hide resolved
.github/workflows/announce-new-release.yml Outdated Show resolved Hide resolved
.github/workflows/announce-new-release.yml Outdated Show resolved Hide resolved
Co-authored-by: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com>
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for having taken time to discuss and challenge my feedback.

@csouchet
Copy link
Member Author

LGTM, thanks for having taken time to discuss and challenge my feedback.

Thanks to you 😄

@csouchet csouchet merged commit fe426a9 into master Dec 29, 2022
@csouchet csouchet deleted the 2341-Add_a_workflow_to_announce_a_new_release_from_a_template branch December 29, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INFRA] Add a workflow to announce a new release from a template
2 participants