Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] check labels in view e2e tests #352

Merged
merged 12 commits into from
Jun 30, 2020

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Jun 25, 2020

View tests
the BPMN is passed to the page and then automatically load it. Then it is possible to check the rendering directly in the page.

Dom tests
use pupetteer jsdom to expect things in the DOM (should be faster that with view tests)

Remaining tasks

  • restore jsdom tests
  • share BPMN content in a fixture file
  • review the way the page load the BPMN passed as url parameter

closes #279

@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Jun 25, 2020
@tbouffard tbouffard changed the title WIP view e2e test: check labels [TEST] check labels in view e2e tests Jun 25, 2020
@tbouffard tbouffard added the WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft label Jun 25, 2020
the bpmn is passed to the page and then automatically load it. Then it is
possible to check the rendering directly in the page

remove expectations with jsdom

test label

test sequence flows

improve demo startup

Add Todo about bpmnStartTaskEnd()
@tbouffard tbouffard force-pushed the 279-280-e2e_view_tests_check_labels branch from cf65c5e to 6d1e469 Compare June 25, 2020 10:19
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aibcmars aibcmars marked this pull request as ready for review June 30, 2020 13:41
@aibcmars aibcmars removed the WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft label Jun 30, 2020
@aibcmars aibcmars merged commit 79c99d4 into master Jun 30, 2020
@aibcmars aibcmars deleted the 279-280-e2e_view_tests_check_labels branch June 30, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Render the Shape Label Bounds
2 participants