Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] Bump mxgraph-type-definitions from 1.0.2 to 1.0.3 #409

Merged
merged 2 commits into from
Jul 9, 2020
Merged

[INFRA] Bump mxgraph-type-definitions from 1.0.2 to 1.0.3 #409

merged 2 commits into from
Jul 9, 2020

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Jul 9, 2020 •
edited
Loading

More mxgraph-type-definitions usages in production code

  • replace ts-mxgraph canvas2D types by mxAbstractCanvas2D when possible
  • keep integer values for DEFAULT_DASHED and DEFAULT_FIX_DASH: the mxUtils
    code isn't able to correctly convert the string into boolean
  • update some TODO for remaining ts-mxgraph usages

covers #368

@tbouffard tbouffard added dependencies Pull requests that update a dependency (dev or runtime) depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first labels Jul 9, 2020
@tbouffard
[INFRA] Bump mxgraph-type-definitions from 1.0.2 to 1.0.3
8344a88 
More `mxgraph-type-definitions` usages in production code
  - replace ts-mxgraph canvas2D types by mxAbstractCanvas2D when possible
  - keep integer values for DEFAULT_DASHED and DEFAULT_FIX_DASH: the mxUtils
  code isn't able to correctly convert the string into boolean
  - update some TODO for remaining ts-mxgraph usages
@tbouffard tbouffard force-pushed the 368-infra_use_mgraph-type-definitions_1.0.3 branch from e47c328 to 8344a88 Compare July 9, 2020 12:48
@tbouffard tbouffard removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Jul 9, 2020
@tbouffard tbouffard marked this pull request as ready for review July 9, 2020 12:52
@tbouffard
Copy link
Member Author

For reviewers:

  • I did my best to check that the rendering hasn't been impacted by the change. I did that using our test BPMN diagrams
  • Please redo the tests (at least a part of them and/or with other files) to double check

@tbouffard tbouffard requested a review from aibcmars July 9, 2020 15:02
@tbouffard tbouffard merged commit 0e2321c into master Jul 9, 2020
@tbouffard tbouffard deleted the 368-infra_use_mgraph-type-definitions_1.0.3 branch July 9, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csouchet csouchet csouchet approved these changes

@aibcmars aibcmars Awaiting requested review from aibcmars

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency (dev or runtime)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbouffard @csouchet