[REFACTOR] Mutualize marker and isExpanded fields in the internal model #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
depends on another PR ⚠️
csouchet
force-pushed
the
refactor/mutualize_marker_and_isExpanded_in_internal_model
branch
2 times, most recently
from
770921f
to
f17f7a1
Compare
tbouffard
force-pushed
the
refactor/mutualize_marker_and_isExpanded_in_internal_model
branch
from
f17f7a1
to
a117565
Compare
tbouffard
removed
the
depends on another PR ⚠️
tbouffard
approved these changes
Aug 6, 2020
| } else if (ShapeUtil.isSubProcess(kind)) { | ||
| shapeBpmnElement = this.buildShapeBpmnSubProcess(bpmnElement, processId); | ||
| } else if (ShapeUtil.isActivity(kind)) { | ||
| shapeBpmnElement = this.buildShapeBpmnActivity(bpmnElement, kind, processId); |
|
|
||
| get marker(): ShapeBpmnMarkerKind { | ||
| return this._marker; | ||
| export class ShapeBpmnActivity extends ShapeBpmnElement { |
tbouffard
deleted the
refactor/mutualize_marker_and_isExpanded_in_internal_model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies markers management and prepare the model for the compensation marker.