[REFACTOR] simplify BpmnCanvas creation in IconPainter #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
depends on another PR ⚠️
tbouffard
changed the title
Remove duplication by introducing a method in charge of creating a new `BpmnCanvas` instance using a `PaintParameter` and additional arguments.
tbouffard
force-pushed
the
refactor/simplify_BpmnCanvas_creation_in_IconPainter
branch
from
91b4f87
to
4d5ac50
Compare
tbouffard
removed
the
depends on another PR ⚠️
csouchet
approved these changes
Aug 11, 2020
csouchet
reviewed
Aug 11, 2020
| public paintEnvelopeIcon({ c, ratioFromParent, setIconOrigin, shape, icon }: PaintParameter): void { | ||
| const originalIconSize = { width: 485.41, height: 321.76 }; | ||
| const canvas = new BpmnCanvas({ | ||
| protected newBpmnCanvas({ c, ratioFromParent, setIconOrigin, shape, icon }: PaintParameter, originalIconSize: Size): BpmnCanvas { |
csouchet
deleted the
refactor/simplify_BpmnCanvas_creation_in_IconPainter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplication by introducing a method in charge of creating a new
BpmnCanvasinstance using aPaintParameterand additional arguments.This will also simplify implementation of new icons and extensions.