[REFACTOR] painting code easier to extend #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
the
lib extensibility
csouchet
reviewed
Aug 13, 2020
Add TSDoc in IconPainter and BpmnCanvas Rename methods - IconPainter `user task icon`: use a generic name (not related to woman even if this is what we are painting by default) to clarify the method purpose - BpmnCanvas `set icon origin`: clarify what methods do
csouchet
force-pushed
the
refactor/Iconpainter_method_name_ready_for_extension
branch
from
edb3fb8
to
b414495
Compare
Co-authored-by: Souchet Céline <4921914+csouchet@users.noreply.github.com>
csouchet
approved these changes
Aug 13, 2020
csouchet
deleted the
refactor/Iconpainter_method_name_ready_for_extension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TSDoc in IconPainter and BpmnCanvas
Rename methods
user task icon: use a generic name (not related to woman evenif this is what we are painting by default) to clarify the method purpose
set icon origin: clarify what methods doThis integrates feedbacks collected when implementing the first set of examples.