Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] improve visual test for sequence flows #626

Merged
merged 5 commits into from
Sep 16, 2020
Merged

[TEST] improve visual test for sequence flows #626

merged 5 commits into from
Sep 16, 2020

Conversation

aibcmars
Copy link
Contributor

@aibcmars aibcmars commented Sep 15, 2020 •
edited by tbouffard
Loading

Add visual test for sequence flows with

  • complex paths
  • conditional and default markers

covers #541

@aibcmars aibcmars added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Sep 15, 2020
@tbouffard
Copy link
Member

@aibcmars can you remove labels and thresholds? we don't need to have labels here, they are already tested in another diagram.
Please remind to avoid labels most of the time (see testing guildelines)

@aibcmars
Copy link
Contributor Author

@aibcmars can you remove labels and thresholds? we don't need to have labels here, they are already tested in another diagram.
Please remind to avoid labels most of the time (see testing guildelines)

yes, mistakenly added after tests for messageFlows (with labels)

@tbouffard tbouffard changed the title [INFRA] visual test for sequence flows [TEST] improve visual test for sequence flows Sep 15, 2020
tbouffard
tbouffard approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbouffard tbouffard mentioned this pull request Sep 15, 2020
Closed
8 tasks
@tbouffard tbouffard merged commit 8eb503d into master Sep 16, 2020
@tbouffard tbouffard deleted the 541-visual_test_sequence_flows_labels branch September 16, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aibcmars @tbouffard