Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Allow to navigate the BPMN diagram with panning #733

Merged
merged 26 commits into from
Oct 13, 2020
Merged

[FEAT] Allow to navigate the BPMN diagram with panning #733

merged 26 commits into from
Oct 13, 2020

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Oct 12, 2020 •
edited
Loading

Introduce

  • a new demo page with fixed size viewport: with floating size, the viewport is resized on panning which is not user friendly
  • new e2e navigation tests to start testing mouse user actions.

closes #590

@tbouffard tbouffard mentioned this pull request Oct 12, 2020
Merged
@tbouffard tbouffard added the enhancement New feature or request label Oct 12, 2020
aibcmars and others added 16 commits October 12, 2020 16:24
@tbouffard tbouffard marked this pull request as ready for review October 13, 2020 08:03
tbouffard
tbouffard commented Oct 13, 2020
View reviewed changes
src/bpmn-visualization.ts Outdated
@@ -27,6 +27,7 @@ export { StyleConfigurator };
export { ShapeUtil };
// end of 'TO DO remove dedicated import/export'

export * from './component/BpmnVisualization';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ I am not sure we need this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking to explicitly export BpmnVisualizationOptions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point here is BpmnVisualizationOptions is a TS interface so it doesn't exist in the transpiled Javascript. But this is going probably interesting for TypeScript integration.
So I will change the export to what you propose.

src/component/mxgraph/MxGraphConfigurator.ts Show resolved Hide resolved
src/component/mxgraph/MxGraphConfigurator.ts Show resolved Hide resolved
@tbouffard tbouffard added the BPMN diagram usability Something about the way we can interact with BPMN diagrams label Oct 13, 2020
aibcmars
aibcmars approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/component/mxgraph/MxGraphConfigurator.ts Show resolved Hide resolved
src/component/mxgraph/MxGraphConfigurator.ts Show resolved Hide resolved
@tbouffard tbouffard merged commit ff67ef7 into master Oct 13, 2020
@tbouffard tbouffard deleted the 590-add-panning branch October 13, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csouchet csouchet csouchet approved these changes

@aibcmars aibcmars aibcmars approved these changes

Assignees
No one assigned
Labels
BPMN diagram usability Something about the way we can interact with BPMN diagrams enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Add Pan capability to the diagram display
3 participants
@tbouffard @csouchet @aibcmars