Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Detect all Cancel Events #777

Merged
merged 7 commits into from
Oct 19, 2020
Merged

[FEAT] Detect all Cancel Events #777

merged 7 commits into from
Oct 19, 2020

Conversation

VickyPicky
Copy link
Contributor

Closes #314

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tbouffard tbouffard added BPMN support Something about the BPMN specification that the lib is already supporting or will support cla not signed The CLA must be signed prior this pull request can be reviewed or merged external contribution 👤 Pull requests provided by someone who is not a core maintainer enhancement New feature or request labels Oct 16, 2020
@csouchet csouchet removed the cla not signed The CLA must be signed prior this pull request can be reviewed or merged label Oct 16, 2020
@aibcmars aibcmars added enhancement New feature or request external contribution 👤 Pull requests provided by someone who is not a core maintainer and removed enhancement New feature or request external contribution 👤 Pull requests provided by someone who is not a core maintainer labels Oct 16, 2020
@csouchet
Copy link
Member

There is an error on the e2e test. The expected parent id of the Interrupting Cancel Boundary Event is not good:
image

csouchet
csouchet requested changes Oct 19, 2020
View reviewed changes
Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 😄
Everything is good, except a little mistake in the e2e. I suggested you the fix.

test/e2e/mxGraph.model.test.ts Outdated Show resolved Hide resolved
test/e2e/mxGraph.model.test.ts Outdated Show resolved Hide resolved
test/fixtures/bpmn/model-complete-semantic.bpmn
@@ -1115,6 +1128,18 @@
<dc:Bounds x="988" y="2156" width="85" height="27" />
</bpmndi:BPMNLabel>
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="shape_end_event_cancel_id" bpmnElement="end_event_cancel_id">
<dc:Bounds x="914" y="2224" width="32" height="32" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the good positioning of the events 😄

csouchet and others added 4 commits October 19, 2020 14:20
@csouchet
Merge branch 'master' into 314-detect_cancel_events
296b6c6
@VickyPicky @csouchet
Update test/e2e/mxGraph.model.test.ts
c9d2743 
Co-authored-by: Souchet Céline <4921914+csouchet@users.noreply.github.com>
@VickyPicky @csouchet
Update test/e2e/mxGraph.model.test.ts
68ab344 
Co-authored-by: Souchet Céline <4921914+csouchet@users.noreply.github.com>
@csouchet
Merge branch 'master' into 314-detect_cancel_events
a7274fc
@csouchet csouchet added the hacktoberfest-accepted Accepted Pull Request during Hacktoberfest label Oct 19, 2020
@csouchet csouchet merged commit cfcf173 into process-analytics:master Oct 19, 2020
@csouchet csouchet changed the title [FEAT] Detect cancel events [FEAT] Detect all Cancel Events Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csouchet csouchet csouchet approved these changes

Assignees
No one assigned
Labels
BPMN support Something about the BPMN specification that the lib is already supporting or will support enhancement New feature or request external contribution 👤 Pull requests provided by someone who is not a core maintainer hacktoberfest-accepted Accepted Pull Request during Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Detect Cancel Events
5 participants
@VickyPicky @CLAassistant @csouchet @tbouffard @aibcmars