static function is not found in RLangPApplet instance in renjin

[gaocegege]

Update summary:

renjin does not currently offer core support for accessing static methods/fields via an instance (bedatadriven/renjin#320). The workaround (e.g. in #134) was to map static functions from RLangApplet in core.R (https://github.com/gaocegege/Processing.R/blob/master/src/rprocessing/r/core.R#L187) -- however if renjin adds core support for static access in the future this could be dropped.

---

radians is a function in PApplet, I am not sure why it raises an error with #95

Instance of class rprocessing.RLangPApplet has no member named 'radians'

It fails examples/Basics/Trigonometry

[gaocegege]

I have found the cause, we will meet the problem when radians, ceil and so on is called.

It seems that renjin couldn't handle the static function well. processing$radians(...) works, but

radians = processing$radians
radians(...)

will return Instance of class rprocessing.RLangPApplet has no member named 'radians'

And

import(rprocessing.RLangPApplet)
radians = RLangPApplet$radians
radians(...)

works well.

[gaocegege]

ref bedatadriven/renjin#320

We could wait the renjin to fix the problem

[jeremydouglass]

Good investigation, and a clear bug report to renjin.

They have been very responsive and supportive so far. Let's see what effort level it would take for renjin to add static variable support, and what kind of priority they can make it.

[gaocegege]

Thank 😄

We have two options, actually:

1. Wait until there is a PR to fix the problem, or file a PR to renjin and fix the problem on our own. Then we could wrap these static functions by xxx = processing$xxx
2. Use xxx = RLangPApplet$xxx instead

And I think we could put the issue to low priority since there is only one function used in the examples. If the issue will be there for a long time, then we could use the latter way to avoid it.

[jeremydouglass]

Great. Then let's set this as low priority since there is a workaround. As we get more coverage of the API we will know how many static functions will be affected by this issue and we can reevaluate.

…

On Wed, Jun 7, 2017 at 06:31 Ce Gao ***@***.***> wrote: Thank 😄 We have two options, actually: 1. Wait until there is a PR to fix the problem, or file a PR to renjin and fix the problem on our own. Then we could wrap these static functions by xxx = processing$xxx 2. Use xxx = RLangPApplet$xxx instead And I think we could put the issue to low priority since there is only one function used in the examples. If the issue will be there for a long time, then we could use the latter way to avoid it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#97 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAwvajyPuRus2AuVREl8BVN5K_Rpy0a1ks5sBqYmgaJpZM4Nxen-> .

[gaocegege]

Done by some tricks in core.R #134

But I think we could keep this open for renjin's update

[jeremydouglass]

Sounds good. Static functions are implemented with the workaround -- but if renjin adds core support for static functions then we can incorporate that.

[jeremydouglass]

2. Use xxx = RLangPApplet$xxx instead
   [...] If the issue will be there for a long time, then we could use the latter way to avoid it.

I've asked a follow-up on this feature for renjin, but I think I will go ahead with option 2 for the next release so that we fix the bug / add the feature. We can change the implementation later if renjin changes.

[gaocegege]

SGTM