Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-processor: Remove processing prefix #95

Merged
merged 5 commits into from
Jun 6, 2017
Merged

Pre-processor: Remove processing prefix #95

merged 5 commits into from
Jun 6, 2017

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jun 6, 2017

It causes an error: fail to pass the test because of there is no core.R in test-output, maybe.

ref #9

Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
@gaocegege gaocegege merged commit 48d71a9 into master Jun 6, 2017
@gaocegege gaocegege deleted the pre-processor branch June 6, 2017 15:25
@gaocegege gaocegege mentioned this pull request Jun 6, 2017
@gaocegege gaocegege modified the milestones: Evaluation 1, Evaluation 2 Jun 8, 2017
@jeremydouglass
Copy link
Member

You said: "maybe we need to add this as a tip into docs." (about processing$foo())

Where in the docs do you think it should be added?

@gaocegege
Copy link
Member Author

Maybe limitations in the user guide? Actually I am not sure about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants