Added exponentialRampToValueAtTime feature #428
Conversation
|
@therewasaguy |
|
I will be adding unit tests for this soon 😊 |
There was a problem hiding this comment.
@endurance21 I have similar feedback to the comment on the new feature PR:
As far as new features go, a key decision from the recent p5 Contributors Conference is that "p5.js will not add any new features except those that increase access" (more here)
So let's keep that in mind as p5 contributors. New features add complexity and we should focus on making the existing features as stable and accessible as can be.
One way to make the library more accessible is to make the API more consistent.
This PR would add a feature to p5.Gain's amp method without adding it to other amp methods. This makes the API inconsistent (moreso than it already is!). I think the inconsistencies make the library less accessible and more confusing.
I think this is a good idea if it can be implemented in a consistent way. But first I would prioritize making the API consistent before adding new features.
|
@endurance21 how would you feel about adding this idea to the backlog for now? |
fixes
#427