Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip link for better keyboard accessibility Fix-#3084 #3101

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

Chaitanya1672
Copy link
Contributor

@Chaitanya1672 Chaitanya1672 commented Apr 27, 2024

Fixes #3084

Hi @raclim please merge this fix.

Changes:
Added skip link functionality to the project. I have included a skip link for the "Play Sketch" button for the time being. But we are able to add additional skip-links as needed. I've written the code accordingly, a demo is shown below. Please let me know if you require any more steps for this patch, or if any UI modifications or skip links need to be introduced.

Steps to check fix:-
-> Go to IDE view
-> Click Tab on keyboard
-> Click Enter

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Preview Video:-

Skip.Link.Fix.Preview.mp4

@raclim raclim added Area:Accessibility Category for accessibility related features and bugs Bug labels Jun 3, 2024
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work on this, this is fantastic! I think there could be improvements to it down the line, but I feel that we could merge this in for now as a starting point and receive feedback from users and make adjustments to it as they come!

@raclim raclim merged commit 298c51d into processing:develop Jun 13, 2024
1 check passed
@Chaitanya1672 Chaitanya1672 deleted the fix/missing-skip-link branch June 14, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Accessibility Category for accessibility related features and bugs Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing skip link
2 participants