Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic HTML issues in header section #2967

Closed
lindapaiste opened this issue Jan 27, 2024 · 4 comments · Fixed by #3130
Closed

Semantic HTML issues in header section #2967

lindapaiste opened this issue Jan 27, 2024 · 4 comments · Fixed by #3130
Labels
Area:Accessibility Category for accessibility related features and bugs Good First Issue Priority:High

Comments

@lindapaiste
Copy link
Collaborator

lindapaiste commented Jan 27, 2024

Increasing Access

Using proper semantic HTML allows screen readers to understand our content.

Feature enhancement details

I found two issues relating to the header section while running an accessibility check:

  1. We have a <header> element inside another <header> element, and multiple <header> elements on mobile. We need to get this down to one. We can change incorrect ones to either a React Fragment or a <div> or potentially remove them from the tree entirely.
  2. We have a <span> as a direct child of a <ul> in the "login or signup" part of the nav bar. Probably we change the <span>or</span> to <li>or</li>. It would also be acceptable to have the entire "login or signup" as one list item, but making the "or" into its own list item is probably easier to implement.

We want to fix these HTML structures without changing the style.

@lindapaiste lindapaiste added Area:Accessibility Category for accessibility related features and bugs Good First Issue labels Jan 27, 2024
@raclim raclim added this to the MINOR Release for 2.12.0 milestone Jan 30, 2024
@vaishnavi192
Copy link

@lindapaiste for issues which have PR linked with them are considered as closed right?

@asimdelvi
Copy link

Can you assign me this issue?

@Simran-Sunil
Copy link

Can I work on this issue?

@Bhavyabhardwaj
Copy link

anyone working on this issue ? if not can i work on this....?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment