Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes/ Semantic Html Issues #2970

Conversation

Mubashirshariq
Copy link
Contributor

Fixes #2967

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@Mubashirshariq
Copy link
Contributor Author

@lindapaiste plz review

@lindapaiste lindapaiste added the Area:Accessibility Category for accessibility related features and bugs label Jan 28, 2024
@@ -9,7 +9,7 @@ const Header = (props) => {
const project = useSelector((state) => state.project);

return (
<header>
<>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it makes sense to keep the <header> here and remove the one in in the NavBar component instead? It's subjective. It depends on whether we consider the toolbar with the play button etc. to be part of the header or not. I can see the arguments for both ways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my perspective, centralizing the header in the NavBar component aligns with a cleaner and more cohesive design, emphasizing a unified user interface.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But still if you want i will remove the one in the Navbar one and keep this one.

@raclim
Copy link
Collaborator

raclim commented Jun 3, 2024

Closing due to addressed by #3130. I'm sorry that we couldn't get this in, but please feel free to check out our other issues!

@raclim raclim closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Accessibility Category for accessibility related features and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic HTML issues in header section
3 participants