Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative Font Size #689

Closed
1 of 3 tasks
Janglee123 opened this issue Sep 11, 2018 · 12 comments
Closed
1 of 3 tasks

Negative Font Size #689

Janglee123 opened this issue Sep 11, 2018 · 12 comments
Labels
Good First Issue Help Wanted Priority:High
Milestone
Post-Release

Comments

@Janglee123
Copy link
Contributor

Nature of issue?

  • Found a bug
  • Existing feature enhancement
  • New feature request
  • Web browser and version: Firefox 62.0 (64-bit)
  • Operating System: Linux (Solus)
  • Steps to reproduce this: Go to website and decrees font size

Details about the bug:

Recently I found that editor font size can be negative
@catarak
Copy link
Member

catarak commented Sep 11, 2018 •
edited
Loading

Thanks for reporting! We probably shouldn't allow that, should we 😄 It probably makes sense to have some lower limit like 8px or something, and also an upper limit.

@Janglee123 Janglee123 mentioned this issue Sep 14, 2018
Merged
@bhawesh96
Copy link
Contributor

This issue can be closed right?

@Janglee123
Copy link
Contributor Author

@bhawesh96 No , I just started working on it but if you want you can work on it

@bhawesh96
Copy link
Contributor

@Janglee123 Alright, I'll do it.

@bhawesh96
Copy link
Contributor

How should the behaviour be? Should the buttons be disabled upon reaching the extreme limits?
Need to handle the case when one enters a font size less than the minimum limit directly into the <input> field.

@Janglee123
Copy link
Contributor Author

Can you make it disappeared at limits ? You can ask it to @catarak

@bhawesh96
Copy link
Contributor

IMO, making it disappear won't be a nice UX.

@catarak
Copy link
Member

catarak commented Oct 4, 2018

@bhawesh96 i agree, i don't think making the buttons disappear is a nice UX! i think what should happen is that once a user has the minimum/maximum size selected, then clicking the -/+ buttons won't do anything. you could disable the buttons (only the - button for minimum value, only the + button for maximum value) too.

i also noticed that you can set the indentation amount to negative values too. maybe it would be good to also give this a smart minimum and maximum value? like 0-6? i think it makes sense to fix this as part of this ticket.

@bhawesh96
Copy link
Contributor

Disabling the buttons do not make the button look disabled as onHover CSS remains. Hence, as a user, I might just keep clicking the button since I'm not being notified about the minimum / maximum value.

@catarak
Copy link
Member

catarak commented Oct 4, 2018

we could add a disabled style!

bhawesh96 added a commit to bhawesh96/p5.js-web-editor that referenced this issue Oct 4, 2018
@bhawesh96
Set min & max limits on font-size
4e2e7ad 
Disable the font-size setting button when extremum is reached.

References processing#689
@bhawesh96 bhawesh96 mentioned this issue Oct 4, 2018
Merged
@catarak catarak added this to the Post-Release milestone Oct 25, 2018
catarak pushed a commit that referenced this issue Nov 2, 2018
@bhawesh96 @catarak
[WIP] Set min & max limits on font-size (#716)
61dd0bb 
* Set min & max limits on font-size

Disable the font-size setting button when extremum is reached.

References #689

* handle case for user input to input field, also add min and max for indentation amount
@bhawesh96
Copy link
Contributor

@catarak This issue can be closed.

@catarak
Copy link
Member

catarak commented Nov 26, 2018

@bhawesh96 thanks!

@catarak catarak closed this as completed Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Help Wanted Priority:High
Projects
None yet
Milestone
Post-Release
Development

No branches or pull requests
3 participants
@catarak @bhawesh96 @Janglee123