Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/switch mobile desktop #1564

Merged

Conversation

ghalestrilo
Copy link
Collaborator

@ghalestrilo ghalestrilo commented Aug 19, 2020

Fixes #1524

This PR integrates mobile and desktop views under the same URLs, updating required redirects on mobile. A quick research indicates that 770px is currently a good breakpoint for rendering mobile (which matches my previous experience with responsive layouts).

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak
Copy link
Member

catarak commented Aug 20, 2020

This is working great for me! Would it be possible to still render the desktop view if MOBILE_ENABLED is false? I'd like to be able to deploy the editor without mobile being enabled until we make sure that the basic user flows work.

@ghalestrilo
Copy link
Collaborator Author

Great point, I'll make sure it works. I'm also working to make the desktop version renderable on mobile if the user prefers.

@ghalestrilo
Copy link
Collaborator Author

ghalestrilo commented Aug 21, 2020

Done. You can now:

  • Control Mobile display with the MOBILE_ENABLED flag
  • Force desktop version to render by clicking ••• > Original Editor

I was thinking: In the future, users may (?) want to

  • Force mobile view: this can be done by creating a new action and updating the utils/responsive#mobileFirst method
  • Store their preference. No idea how to do this 🤷🏻

But I don't think these are priorities right now

@ghalestrilo ghalestrilo self-assigned this Aug 21, 2020
@catarak
Copy link
Member

catarak commented Aug 21, 2020

Working great for me ✨

@ghalestrilo ghalestrilo merged commit d126821 into processing:develop Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Mobile Routing
2 participants