Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed right left arrow to file icon #2890

Conversation

iamnithishraja
Copy link
Contributor

@iamnithishraja iamnithishraja commented Jan 13, 2024

Fixes #2888

Changes:
made src button a file icon for a seemless experience. Made it same as on mobile devices on the desktop.
I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Jan 13, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim
Copy link
Collaborator

raclim commented Mar 28, 2024

Thanks for taking the time to work on this!

Usually for feature enhancements or requests like this that change the UI, we usually want to take some time to deliberate on what the final design would look like. After reviewing the issue I think it needs some further discussion, especially since it'll change a pretty highly used part of the interface. I'm sorry that it wasn't labeled properly at the time, but I don't think we're ready to merge this in yet. I'm going to close this for now, but please feel free to check out our other issues, thank you!

@raclim raclim closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make src button a file icon for a seemless experience.
3 participants