make it possible to call "npm run dev" per docs without having called "npm grunt" first #5391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks. The grunt tasks we have probably can be cleaned up a bit but that's for another day. |
This was referenced Feb 3, 2022
Open
This was referenced Mar 7, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5388
Changes:
yuibuild step as part ofnpm run dev, allowing developers to callnpm run devwithout having callednpm gruntfirst.The documentation states: "If you're continuously changing files in the library, you may want to run npm run dev to automatically rebuild the library ...", implying that you may call
npm run devinstead ofnpm run grunt. This fix makes that possible.PR Checklist
npm run lintpasses