Don't unpack premultiply alpha for text data textures #6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferriss
reviewed
Jun 22, 2023
| @@ -757,6 +759,7 @@ p5.RendererGL.prototype._renderText = function(p, line, x, y, maxY) { | |||
|
|
|||
| this._doStroke = doStroke; | |||
| this.drawMode = drawMode; | |||
| gl.pixelStorei(gl.UNPACK_PREMULTIPLY_ALPHA_WEBGL, true); | |||
There was a problem hiding this comment.
is gl defined in this scope?
There was a problem hiding this comment.
haha you can tell I moved this around -- but it looks like it's already defined on line 684 which is why it didn't break, so I can take out the one I added in this PR!
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6235
Text rendering was breaking because we premultiply alpha on all images that get loaded in to WebGL now. This is good for image rendering, but the text shader passes in data textures where the alpha channel doesn't actually represent the opacity of a color, it just represents numbers. We don't want to mess up the numbers, so I turn it off now in the text shader.
Changes:
UNPACK_PREMULTIPLIED_ALPHAwhen passing data images into the text shaderScreenshots of the change:
PR Checklist
npm run lintpasses