Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for per vertex transparency when blending #6541

Merged

Conversation

davepagurek
Copy link
Contributor

Resolves #6539

Changes

  • Checks (and caches) whether any per vertex colors include transparency
  • Enables blending if that is true

Screenshots of the change

Before:
image

After:
image

Live: https://editor.p5js.org/davepagurek/sketches/QFQV0_K_E

PR Checklist

@Qianqianye
Copy link
Contributor

Thanks @davepagurek. @acamposuribe, could you help review this PR since you opened the related issue? Thanks!

@Qianqianye Qianqianye added this to the 1.9.0 milestone Nov 23, 2023
@Qianqianye Qianqianye mentioned this pull request Nov 23, 2023
7 tasks
@Qianqianye Qianqianye modified the milestones: 1.9.0, 1.9.1 Dec 1, 2023
@davepagurek
Copy link
Contributor Author

Tagging other WebGL stewards and contributors, let me know what you think! @aferriss, @aceslowman, @ShenpaiSharma, @ChihYungChang, @teragramgius, @JazerUCSB, @richardegil, @itsjoopark, @Gaurav-1306, @jeanetteandrews, @perminder-17

Copy link
Contributor

@aferriss aferriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Dave!

Copy link
Contributor

@perminder-17 perminder-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think we are good to merge. Thanks.

@davepagurek
Copy link
Contributor Author

Thanks everyone!

@davepagurek davepagurek merged commit 304ee90 into processing:main Feb 2, 2024
2 checks passed
@davepagurek davepagurek deleted the fix/vertex-color-transparency branch February 2, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fill() bug in p5.Geometry -> strange alpha behaviour
4 participants