Implemented new variables and methods regarding the mouse events #7073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New variables and methods: lastButtonPressed; lastButtonReleased; lastButtonClicked; currentButton; mouseInteractions (Array); mouseInteraction (Class); setSizeInteractionsList(); Added other complementary auxiliary variables and methods; Added the correspondent unit tests for the new variables and methods; Added the necessary documentation to further test the new implemented variables and methods; Co-authored-by: Bianca Fonseca <bianca.fonseca@tecnico.ulisboa.pt>
|
Hi, we usually require an issue to be opened for discussions before a PR should be filed, so that we can work out any implementation details or to indicate that we are not interested in including any specific features in the library before any work is done. Please open a separate issue about what changes you are proposing. I'm closing this for now. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
lastButtonPressed;
lastButtonReleased;
lastButtonClicked;
currentButton;
mouseInteractions (Array);
mouseInteraction (Class);
setSizeInteractionsList();
Added other complementary auxiliary variables and methods;
Added the correspondent unit tests for the new variables and methods;
Added the necessary documentation to further test the new implemented variables and methods.
PR Checklist
npm run lintpasses