Fix race condition in ts_utils:make_dir/1 #109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition, when multiple Erlang VMs are started almost simultaneously which is a typical case if you are not using tsung's SMP option.
I observed it a couple of times now, that
ts_local_mon
failed to write theprotocol_local
dumpfile. The reason is that the check and set is not one atomic operation ints_utils:make_dir_rec/3
. There is a window after the check, when another process could have created the directory already, resulting in a{error, eexist}
.In #88 the check for
ok
ints_local_mon:init/1
was wrongfully removed (I'm sorry for that). Back then I noticed the{error, eexist}
and assumed that this is a result from the fact that the entire log directory already existed, which is not the case.ts_utils:make_dir/1
andts_utils:make_dir_raw/1
should now be better protected against the mentioned race condition.