Work around compiler warning and provide backward compatibility. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While compiling this using erlc, warning thrown: `Warning: crypto:sha_mac/2 is deprecated and will be removed in in a future release; use crypto:hmac/3` In order to support older OTP releases it's better to have crypto:sha_mac there but for new OTPs we should use crypto:hmac instead.
|
Looks like a good idea. I'm wondering though (in general) what the performance impact of |
|
Haven't measured yet, guess no substantial impact. |
|
yes, i checked with timer:tc, it gives 1 or 2 microseconds, which is fine. |
nniclausse
added a commit
that referenced
this pull request
Sep 7, 2015
Work around compiler warning and provide backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While compiling this using erlc, warning thrown:
Warning: crypto:sha_mac/2 is deprecated and will be removed in in a future release; use crypto:hmac/3In order to support older OTP releases it's better to have crypto:sha_mac there but for new OTPs we should use crypto:hmac instead.