Fix connection with websocket ssl#310
Merged
Merged
Conversation
When connecting with server type `websocket_ssl` the handshake wasn't been made correctly. This PR solves issue processone#309.
Collaborator
|
Hi @luisfmcalado! Thanks for your bug report and fix 💕 II've been able to reproduce the issue you've described in #309 and also confirmed your fix. In case someone wants to reproduce, I've been using this configuration: <?xml version="1.0"?>
<!DOCTYPE tsung SYSTEM "/tsung/share/tsung/tsung-1.0.dtd" []>
<tsung loglevel="debug" dumptraffic="true" version="1.0">
<clients>
<client host="localhost" use_controller_vm="true"/>
</clients>
<servers>
<server host="test.mosquitto.org" port="8081" type="websocket_ssl" weight="1" />
</servers>
<load>
<arrivalphase phase="1" duration="10" unit="second">
<users maxnumber="1" arrivalrate="10" unit="second" />
</arrivalphase>
</load>
<options>
<option name="websocket_path" value="/"/>
<option name="websocket_subprotocols" value="mqtt"/>
</options>
<sessions>
<session name="mqtt-subscribe" weight="1" type="ts_mqtt">
<request>
<mqtt type="connect" clean_start="true" timeout="30" keepalive="3600"></mqtt>
</request>
<request><mqtt type="subscribe" topic="/tsung/#" qos="1"></mqtt></request>
<for from="1" to="100" incr="1" var="counter">
<request>
<mqtt type="waitForMessages" timeout="60"></mqtt>
</request>
</for>
<request><mqtt type="disconnect"></mqtt></request>
</session>
</sessions>
</tsung>I've tested this then using mosquitto_pub -h test.mosquitto.org -m "hello tsung" -t '/tsung/test' |
tisba
approved these changes
Jun 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When connecting with server type
websocket_sslthe handshake wasn'tbeen made correctly. This PR solves issue #309.