AsmSelect does not honour disabled attribute of the underlying select

[Toutouwai]

Short description of the issue

Inputfields that extend InputfieldSelect such as Select Multiple, Radio Buttons and Checkboxes honour the "disabled" attribute of options - if the option is disabled it may not be selected.

Example:

$wire->addHookBefore('InputfieldSelect::render', function(HookEvent $event) {
	$inputfield = $event->object;
	if($inputfield->hasField != 'colours') return;
	$inputfield->addOptionAttributes(1062, ['disabled' => 'disabled']);
});

But InputfieldAsmSelect does not honour the disabled attribute of the underlying select that it modifies, allowing disabled options to be selected.

AsmSelect does support disabled options (it disables items in the dropdown after they have been selected) so I expected it carry over disabled options from the underlying select.

Setup/Environment

• ProcessWire version: 3.0.129

[Toutouwai]

Possible fix - replace these lines with:

if($t.is(":selected")) {
	addListItem(id); 
	addSelectOption(id, true); 						
} else if($t.is(":disabled")) {
	addSelectOption(id, true);
} else {
	numActive++;
	addSelectOption(id); 
}

[ryancramerdesign]

Thanks @Toutouwai I have pushed your suggested fix for this.

[Toutouwai]

Thanks.