Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI python version #435

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Fix CI python version #435

merged 1 commit into from
Aug 31, 2021

Conversation

ewjoachim
Copy link
Member

Fix CI python version

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #435 (cd2ae23) into master (03cfbd4) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #435      +/-   ##
===========================================
+ Coverage   99.87%   100.00%   +0.12%     
===========================================
  Files          30        30              
  Lines        1630      1635       +5     
  Branches      178       178              
===========================================
+ Hits         1628      1635       +7     
+ Misses          1         0       -1     
+ Partials        1         0       -1     
Impacted Files Coverage Δ
procrastinate/periodic.py 100.00% <0.00%> (ø)
procrastinate/sql/__init__.py 100.00% <0.00%> (ø)
procrastinate/aiopg_connector.py 100.00% <0.00%> (ø)
procrastinate/worker.py 100.00% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cfbd4...cd2ae23. Read the comment docs.

@ewjoachim
Copy link
Member Author

Haha 😭
I just discovered a typo in the CI that meant we didn't actually test on multiple Python versions. And now it says there's a test that doesn't pass on py 3.6 😓

Copy link
Contributor

@k4nar k4nar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@ewjoachim ewjoachim merged commit 4b2fd7d into master Aug 31, 2021
@ewjoachim ewjoachim deleted the fix-ci-python-version branch August 31, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants