Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming things #81

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Renaming things #81

merged 2 commits into from
Sep 13, 2019

Conversation

ewjoachim
Copy link
Member

Successful PR Checklist:

  • Tests
  • Documentation: nope, internal API only.
  • Had a good time contributing? (if not, feel free to give some feedback)

pmourlanne
pmourlanne approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@pmourlanne pmourlanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍
I noticed that we tend to use multiple (synonymous) words for the same thing. If I spot others I'll try to rectify it.

@ewjoachim
Copy link
Member Author

If I spot others I'll try to rectify it.

By all means, please do :)

@ewjoachim ewjoachim merged commit 5ee0dc0 into master Sep 13, 2019
@ewjoachim ewjoachim deleted the renaming-things branch September 13, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmourlanne pmourlanne pmourlanne approved these changes

@mgu mgu Awaiting requested review from mgu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewjoachim @pmourlanne