Laravel 5.4 Fixes with Tests

[CWDN]

I've updated the code and the tests to work with Laravel 5.4 and thus created breaking changes against previous versions. I wasn't sure what to do with your testing setup as there are multiple composer.json's for the different Laravel versions to be tested. But these don't seem to be needed anymore as the code changes I've done will break on previous Laravel versions.

I've had to create a proxy class for the ValidationRuleParser because its parse function is static and it didn't seem like you could mock static functions. I've done this to allow the DelegatedValidator to be tested. Annoyingly it will be the only class in your code base not being tested, so interested in what your thoughts are.

Thanks
Chris

[antonkomarev]

@torrentalle Can you review this, please?

[antonkomarev]

Not sure if it's working on older Laravel versions but it seems to work in 5.4

[austintoddj]

@torrentalle Would love to see this merged into the project soon! 🙏

[kyranb]

@torrentalle bumpity =)

[jampack]

Been waiting since a week sadly 😞

[drjoju]

OK. The pull request is accepted.

[antonkomarev]

Whoah! =) Thanks @drjoju
There is a requirement to make a release then.

[antonkomarev]

@drjoju This PR breaks backward compatibility #242. So it should be released only in Major release or we should update the code to keep old Laravel versions support before release.

[kamrava]

This PR not working for me:

Type error: Argument 1 passed to Symfony\Component\HttpFoundation\Request::setSession() must be an instance of Symfony\Component\HttpFoundation\Session\SessionInterface, instance of Illuminate\Session\Store given, called in /var/www/vendor/proengsoft/laravel-jsvalidation/src/JsValidatorFactory.php on line 160 (View: /var/www/resources/views/user/drafts/new/sections/_foot.blade.php) (View: /var/www/resources/views/user/drafts/new/sections/_foot.blade.php)

I'm using Laravel 5.4.24

[jampack]

@kamrava you need to update the package from stable version(1.5.0) to dev-master

[antonkomarev]

@kamrava Release not published since it has breaking changes. Feel free to open PRs to return support of Laravel < 5.4 and then we will ready to publish stable release. #242 is show stopper issue.

[jampack]

@a-komarev how come Laravel make such changes in a minor version that break everything backward?

[antonkomarev]

@akkhan20 Laravel don't follow SemVer standard. Laravel 5.1 > 5.2 means something similar like 1.0 > 2.0 in SemVer.