-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leaks in unit tests #1019
Comments
I see some warnings that seem to be invalid like in |
Memory leak detected through unit tests. Regards #1019
muc_init() call without muc_close() Regards #1019
autocomplete_free() calls autocomplete_clear() and then frees the struct itself. Regards #1019
Free `room` string in case we allocated it ourselves. Regards #1019
Valgrind output now:
So all leaks in unit tests should be fixed. Some of the issues even brought general memleaks to daylight. @pasis valgrind gives some more output. Mostly Invalid reads and jumps depending on uninit. values. The latter might be not true becaues it's mostly things from glib lists, and I suspect maybe valgrind can't detect that properly. However I would be happy if you could take a look at some of the invalid reads as I don't quite understand them. Especially the Python related stuff. |
1746f5f was actually not a fix. I reverted it in 7684cf6. So we still have:
I thought we might need something like Any idea here @pasis? |
There are a lot of memory leaks in unit tests:
Steps to reproduce:
make tests/unittests/unittests
valgrind --leak-check=full --show-leak-kinds=definite tests/unittests/unittests
The text was updated successfully, but these errors were encountered: