Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent color generation for nicks (XEP-0392) #1191

Closed
jubalh opened this issue Sep 13, 2019 · 5 comments
Closed

Use consistent color generation for nicks (XEP-0392) #1191

jubalh opened this issue Sep 13, 2019 · 5 comments
Assignees
Labels
Milestone

Comments

@jubalh
Copy link
Member

@jubalh jubalh commented Sep 13, 2019

Expected Behavior

Have a consistent color for nicknames (etc).

Current Behavior

Use the color defined in the theme.

Solution

We should implement XEP-0392.

@jubalh jubalh added the feature label Sep 13, 2019
@mdosch

This comment has been minimized.

Copy link
Contributor

@mdosch mdosch commented Sep 25, 2019

Right now profanity shows the online status by color of the nickname in the occupants list. Will this behavior remain?
I could imagine to keep a fixed color depending on the online state in the occupants list to prevent it from looking like a rainbow but use the consistent nickname colors in the message area.

@jubalh

This comment has been minimized.

Copy link
Member Author

@jubalh jubalh commented Sep 25, 2019

Good point. Your suggestion makes sense. I can also see me implementing it as a setting.

@mdosch

This comment has been minimized.

Copy link
Contributor

@mdosch mdosch commented Sep 25, 2019

@jubalh

This comment has been minimized.

Copy link
Member Author

@jubalh jubalh commented Sep 25, 2019

Which means generally turning of this color feature, not individual for the roster/occupants.

jubalh added a commit that referenced this issue Dec 9, 2019
The last 3 commits added basic support.
Thanks @aaptel!

This commit adds basic settings interface to use it.
See `/color on|off`.

We still have to enable settings for color blindness.
And maybe another setting to decide whether to color the
occupantslist/roster with the same algo.

Regards #1191
@jubalh jubalh added this to the 0.8.0 milestone Dec 9, 2019
jubalh added a commit to profanity-im/profanity-im.github.io that referenced this issue Dec 9, 2019
jubalh added a commit to profanity-im/profanity-im.github.io that referenced this issue Dec 9, 2019
jubalh added a commit that referenced this issue Dec 12, 2019
Implement settings for redgreen and blue blindness.

Regards #1191
jubalh added a commit to profanity-im/profanity-im.github.io that referenced this issue Dec 12, 2019
Is done now in developemtn, including color vision deficiancy.

Regards profanity-im/profanity#1191
@jubalh jubalh closed this Dec 12, 2019
jubalh added a commit that referenced this issue Dec 19, 2019
`/roster color on|off` to enable or disable XEP-0392 also for the
roster.

Regards #1191
jubalh added a commit that referenced this issue Dec 19, 2019
`/occupants color on|off` to enable or disable XEP-0392 also for the
MUC occupants.

Regards
#1191
@jubalh

This comment has been minimized.

Copy link
Member Author

@jubalh jubalh commented Dec 19, 2019

Colors for the roster and occupants can now also be enabled!

mdosch referenced this issue in profanity-im/blog Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.