Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profanity crashes when OMEMO key is misconfigured #1239

Closed
immae opened this issue Dec 15, 2019 · 0 comments
Closed

Profanity crashes when OMEMO key is misconfigured #1239

immae opened this issue Dec 15, 2019 · 0 comments
Milestone

Comments

@immae
Copy link
Contributor

immae commented Dec 15, 2019

Expected Behavior

Buggy clients may put incorrect values in eu.siacs.conversations.axolotl signedPreKeyPublic. profanity should ignore those keys and continue working.

Current Behavior

My example was with an incorrect key of the form <signedPreKeyPublic signedPreKeyId="34980">b'BR4qa16J7e2LhVcUhjsjkosCD9HAqrKo0H3ZIYWVjnVU'</signedPreKeyPublic> (notice the b' at the beginning of the string), stored by a buggy python client (namely https://gitlab.com/ecartman/sleekxmpp-omemo-plugin/ )

profanity complained and crashed.

Possible Solution

Only workaround I found is to remove manually the incorrect keys

Steps to Reproduce (for bugs)

  1. Store an incorrect omemo key for a buddy
  2. Start profanity

Environment

  • Give us the version and build information output generated by profanity -v
Profanity, version 0.7.1
Copyright (C) 2012 - 2019 James Booth <boothj5web@gmail.com>.
Copyright (C) 2019 Michael Vetter <jubalh@iodoru.org>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libmesode
Desktop notification support: Enabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.12.0)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Enabled (3.7.4)
GTK icons: Enabled
  • Operating System/Distribution
    nixpkgs package on archlinux
@jubalh jubalh added this to the 0.8.0 milestone Dec 15, 2019
paulfariello added a commit to paulfariello/profanity that referenced this issue Jan 11, 2020
paulfariello added a commit to paulfariello/profanity that referenced this issue Jan 11, 2020
paulfariello added a commit to paulfariello/profanity that referenced this issue Jan 11, 2020
paulfariello added a commit to paulfariello/profanity that referenced this issue Jan 20, 2020
@jubalh jubalh closed this as completed in 0dfed1f Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants