Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cycle through Nicknames breaks on slashes #1474

Closed
kaffeekanne opened this issue Jan 28, 2021 · 3 comments · Fixed by #1646
Closed

Cycle through Nicknames breaks on slashes #1474

kaffeekanne opened this issue Jan 28, 2021 · 3 comments · Fixed by #1646
Labels
bug good-first-issue help wanted

Comments

@kaffeekanne
Copy link
Contributor

When cycling through nicknames with tab in a MUC, it stops when there is a nickname containing slash /.

Expected Behavior

Cycle through all nicknames.

Current Behavior

Cycles until the nick starting with / is reached.

Possible Solution

Steps to Reproduce (for bugs)

  1. Have a MUC with a participant named /something
  2. Have an empty input window
  3. cycle through nicknames to mention with tab
  4. upon reaching nick /something, further cycling with tab stops working

Context

Since i can't type cyrillic letters i tried to tab until that nick is reached to be highlighted.

Environment

Profanity, version 0.10.0
Copyright (C) 2012 - 2019 James Booth <boothj5web@gmail.com>.
Copyright (C) 2019 - 2021 Michael Vetter <jubalh@iodoru.org>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Disabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.14.0-unknown)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Disabled
GTK icons: Disabled

Raspberry Pi OS (Debian Testing/Bullseye)
@jubalh jubalh added this to the 0.11.0 milestone Jan 28, 2021
@jubalh
Copy link
Member

jubalh commented Jun 9, 2021

@mwuttke97 something for you?

@jubalh jubalh added the bug label Jun 29, 2021
@jubalh
Copy link
Member

jubalh commented Jun 30, 2021

@mwuttke97 if I remember correctly you mentioned in the MUC that this bug should be trivial. Do you think you can tackle it soonish so it will be in 0.11? :)

@jubalh
Copy link
Member

jubalh commented Jul 2, 2021

@xenrox do you think you have time to tackle this one?

@jubalh jubalh modified the milestones: 0.11.0, 0.12.0 Jul 5, 2021
@jubalh jubalh removed this from the 0.12.0 milestone Feb 23, 2022
MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue Mar 3, 2022
@MarcoPolo-PasTonMolo
Fix not autocompleting nicks with '/'
1afe2aa 
Remove check for '/' at the beginning of the line before autocompleting
and make it fallback to command autocompletion if no nicks found.

Fixes profanity-im#1474
@MarcoPolo-PasTonMolo MarcoPolo-PasTonMolo mentioned this issue Mar 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good-first-issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix not autocompleting nicks with '/' MarcoPolo-PasTonMolo/profanity
2 participants
@jubalh @kaffeekanne