Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocompletion for quotes #1649

Closed
MarcoPolo-PasTonMolo opened this issue Mar 20, 2022 · 3 comments · Fixed by #1651
Closed

Add autocompletion for quotes #1649

MarcoPolo-PasTonMolo opened this issue Mar 20, 2022 · 3 comments · Fixed by #1651
Assignees
@MarcoPolo-PasTonMolo
Labels
feature
Milestone
0.12.0

Comments

@MarcoPolo-PasTonMolo
Copy link
Collaborator

Autocomplete previous messages when > is typed at the beginning of the line

I already have implemented most of this. Just posting this to be sure that it is something that's accepted by the main devs.

Expected Behavior

When I type > and then tab or shift tab previous messages should autocomplete

Current Behavior

No previous message autocompetion
@jubalh
Copy link
Member

jubalh commented Mar 20, 2022

So what would the workflow look like? I guess something like:

  • type >
  • tab until correct message is autocompleted
  • press key to open editor
  • enter for newline
  • type reply

Or do you have another plan about the newline so that the formatting in other clients will be correct for the quote?

@MarcoPolo-PasTonMolo
Copy link
Collaborator Author

That's the workflow I had in mind

@jubalh
Copy link
Member

jubalh commented Mar 21, 2022

Sounds good to me!

@jubalh jubalh added the feature label Mar 21, 2022
@jubalh jubalh added this to the 0.12.0 milestone Mar 21, 2022
MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue Mar 21, 2022
@MarcoPolo-PasTonMolo
Add quote autocompletion for previous messages
06ef684 
Fixes profanity-im#1649

Type `>` then press tab or shift tab to autocomplete previous messages,
then type your reply and send message.
Newlines are replaced with newline followed by `> `.
A newline is added at the end so that the user can immediately type a
message without manually adding a new line.
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcoPolo-PasTonMolo MarcoPolo-PasTonMolo

Labels
feature
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Add quote autocompletion for previous messages MarcoPolo-PasTonMolo/profanity
2 participants
@jubalh @MarcoPolo-PasTonMolo