Add quote autocompletion for previous messages #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes profanity-im#1649 Type `>` then press tab or shift tab to autocomplete previous messages, then type your reply and send message. Newlines are replaced with newline followed by `> `. A newline is added at the end so that the user can immediately type a message without manually adding a new line.
|
|
|
Debian 12 has 2.66.8 |
|
Ok, I better change that then |
|
You can also put some ifdef around it (I think we have that in other parts). And later when all distros have this version of the lib we will remove the alternative way. |
|
Sorry I don't know how to do that |
jubalh
reviewed
Mar 21, 2022
|
|
||
| GString* replace_with = g_string_new("> "); | ||
| g_string_append(replace_with, quoted_result); | ||
| g_string_append(replace_with, "\n"); |
There was a problem hiding this comment.
Is this working for you? When I open in the editor I'm still on the same line.
There was a problem hiding this comment.
If I open it in vim no, if I open it in another editor yes. Also if I don't open it in editor and just write something, the newline is indeed present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1649
Type
>then press tab or shift tab to autocomplete previous messages,then type your reply and send message.
Newlines are replaced with newline followed by
>.A newline is added at the end so that the user can immediately type a
message without manually adding a new line.
I'm not sure if win_quote_autocomplete is in the correct file. I thought ui/window_list.c might have also been a good place to put it in since there are some other related functions there.