Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember encryption status for PGP and Ox #1694

Closed
mdosch opened this issue Apr 18, 2022 · 4 comments · Fixed by #1722
Closed

Remember encryption status for PGP and Ox #1694

mdosch opened this issue Apr 18, 2022 · 4 comments · Fixed by #1722
Assignees
@MarcoPolo-PasTonMolo
Labels
feature
Milestone
0.13.0

Comments

@mdosch
Copy link
Contributor

mdosch commented Apr 18, 2022 •
edited

If I enable PGP or Ox for an contact I have to remember to perform /pgp start or /ox start every time I restart profanity as I will otherwise accidentally send unencrypted messages. For /omemo start profanity remembers the encryption stat.

Expected Behavior

Activate PGP or Ox encryption for chats where it was enabled before.

Current Behavior

Profanity forgets the state for PGP and Ox.

Environment

Debian Unstable

profanity -v                                                                      :(
Profanity, version 0.12.1dev.master.8ffd8079
Copyright (C) 2012 - 2019 James Booth <boothj5web@gmail.com>.
Copyright (C) 2019 - 2021 Michael Vetter <jubalh@iodoru.org>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.16.0-unknown)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Disabled
GTK icons/clipboard: Disabled
@jubalh
Copy link
Member

jubalh commented Apr 18, 2022

Isn't there already an issue for this?

@mdosch
Copy link
Contributor Author

mdosch commented Apr 18, 2022 via email

@jubalh
Copy link
Member

jubalh commented Apr 20, 2022

Aren't these the same?

@mdosch
Copy link
Contributor Author

mdosch commented Jun 16, 2022

There was none for Ox. 😁

MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue Jun 17, 2022
@MarcoPolo-PasTonMolo
Don't forget encryption status for OX and PGP.
e4e53d6 
Use a pgp.enabled and ox.enabled array the same way that omemo.enabled
is used.

Fixes profanity-im#1694
Fixes profanity-im#733
Merged
@jubalh jubalh added the feature label Jun 17, 2022
@jubalh jubalh added this to the 0.13.0 milestone Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcoPolo-PasTonMolo MarcoPolo-PasTonMolo

Labels
feature
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Don't forget encryption status for OX and PGP. MarcoPolo-PasTonMolo/profanity
3 participants
@jubalh @mdosch @MarcoPolo-PasTonMolo