Send and retrieve encrypted files when using OMEMO #1375

wstrm · 2020-06-27T15:22:27Z

Fixes: #1262

Neustradamus · 2020-11-16T17:39:56Z

@wstrm: Have you progressed on it?

The Content-Disposition inferring is probably a bad idea security wise, so I am going to remove it.

wstrm · 2020-11-16T20:59:32Z

@wstrm: Have you progressed on it?

No, not lately. Hopefully I'll get back to it soon.

src/config/preferences.c

wstrm · 2020-12-07T14:59:07Z

@jubalh Show no mercy

jubalh

See comments in code plus:

Where do you use omemo_free()
You added two empty files: src/tools/aesgcm_upload.c src/tools/aesgcm_upload.h

jubalh · 2020-12-07T15:04:43Z

src/command/cmd_defs.c

-              "/omemo trust c4f9c875-144d7a3b-0c4a05b6-ca3be51a-a037f329-0bd3ae62-07f99719-55559d2a",
-              "/omemo untrust loki@valhalla.edda c4f9c875-144d7a3b-0c4a05b6-ca3be51a-a037f329-0bd3ae62-07f99719-55559d2a",
-              "/omemo char *")
+        parse_args, 1, 3, NULL,


indentation got changed here. I know.. its a bit of a problem because we don't use default here.. :-/

I shouldn't do something here, right? :)

src/command/cmd_funcs.h

src/omemo/omemo.h

src/ui/console.c

jubalh · 2020-12-07T16:36:11Z

I like a lot what you did to http upload!

Some more reviewing:

/executable prints:

17:31:01 - Default '/avatar open' command (/executable avatar)                      : xdg-open
17:31:01 - Default '/url open' command (/executable urlopen)                        : false;xdg-open %u;
17:31:01 - Default '/url save' command (/executable urlsave)                        : (null)

What happens when a user sets /executable urlsave aesgcm "omut -d -o %p %u" which is still mentioned in /help executable and later wants to go back to default?
/executable urlsave (<protocol>|DEF) <cmd> is also mentioned in /help executable but setting /executable urlsave DEF (null) won't work.

So first I think /help executable needs an update. And second we need a way to reset to default.

jubalh

Looking good! Except that you don't expand ~. So /url save https://profanity-im.github.io/faq.html ~/something will make trouble.

unique_filename_from_url() is used for `/url save`. It doesn't recognize ~ by itself, we need to expand it first. Mentioned in #1375 (review)

#1375 added omemo media sharing support. Thus the protection (#1270) to sending files plainly in an omemo chat isn't needed anymore and got removed. Lets clean it from the config file.

jubalh · 2020-12-09T07:46:23Z

I opened #1447 for the last comment.

jubalh · 2020-12-09T07:47:01Z

@wstrm Thanks a lot for your work! This will be a nice christmas present for users!

Neustradamus · 2020-12-09T23:11:44Z

@wstrm: Thanks for your job in Profanity!

I am not sure if https://github.com/wstrm/omemo-utils is compatible with all OMEMO 0.3.0 clients:

"AES128_GCM_IV_LENGTH"
"AES128_GCM_KEY_LENGTH"
"AES128_GCM_TAG_LENGTH"

jubalh added this to the 0.10.0 milestone Jun 27, 2020

jubalh added the feature label Jun 27, 2020

wstrm force-pushed the feature/omemo-sendfile branch from 02dd25b to 42be1b7 Compare July 2, 2020 17:24

wstrm force-pushed the feature/omemo-sendfile branch 3 times, most recently from af79e3b to 0476ddc Compare July 21, 2020 09:51

wstrm added 22 commits November 16, 2020 21:58

Initial /sendfile OMEMO encryption

3370418

Refactor to use file stream

39c3290

Reformat HTTP get URL to AESGCM scheme

e9d5875

Move setup for AESGCM to omemo/crypto

d5b1dc0

Remove unused #define's and move URL scheme define to omemo/crypto.h

fc6136d

Add guards for OMEMO

e98644f

Move file encryption function to public header

f4ab1ca

Remove /omemo sendfile

9d58472

Remove temporary ciphertext file when finished

04bfa23

Wording

362c697

Add http_download tool

9499df6

Infer filename from content-disposition or URL

eebf54c

The Content-Disposition inferring is probably a bad idea security wise, so I am going to remove it.

Remove unsafe Conent-Disposition inferring

a0cf084

Run make format on rebase

4711fc6

Use fallback method when /executable urlsave is unset

fb002a5

Refactor OMEMO download into AESGCMDownload tool

73f313b

Add I/O error handling and use filenames instead of file descriptors

62cbad1

Explicitly clear fragment from HTTP URL

7a1eb73

Move common http tool code to http_common

3d344cf

Switch to g_strerror

ab83afe

Add stubs

be62b44

Fix stubs and move some tests to http_common

1bb6cec

wstrm force-pushed the feature/omemo-sendfile branch from f0988eb to 1bb6cec Compare November 16, 2020 20:58

wstrm self-assigned this Nov 16, 2020

Refactor for threaded external executable for built-in download methods

3a6597e

jubalh reviewed Dec 3, 2020

View reviewed changes

src/config/preferences.c Outdated Show resolved Hide resolved

wstrm added 3 commits December 4, 2020 16:13

Move unique_filename_from_url functions to common

1d2c0a8

Rework url to filename

ac03037

Fix bad order of parameters for url save

4a1c118

wstrm marked this pull request as ready for review December 7, 2020 14:58

Add tests for format_call_external_argv

867d895

jubalh requested changes Dec 7, 2020

View reviewed changes

wstrm added 3 commits December 7, 2020 16:30

Remove cmd_tiny, empty files and link nonce with IV

5c5b4d7

Fix wrong order of arguments for _url_http_method

332dc87

Fix segfault for urlopen[1]

7f0165a

wstrm requested a review from jubalh December 7, 2020 15:51

Remove scheme and filetype matching for url (save|open)

d7848e3

jubalh approved these changes Dec 9, 2020

View reviewed changes

jubalh merged commit 7a319df into profanity-im:master Dec 9, 2020

jubalh added a commit that referenced this pull request Dec 9, 2020

Expand ~ in unique_filename_from_url()

a2291b3

unique_filename_from_url() is used for `/url save`. It doesn't recognize ~ by itself, we need to expand it first. Mentioned in #1375 (review)

jubalh added a commit that referenced this pull request Dec 9, 2020

Purge omemo sendfile from config

5179b25

#1375 added omemo media sharing support. Thus the protection (#1270) to sending files plainly in an omemo chat isn't needed anymore and got removed. Lets clean it from the config file.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Send and retrieve encrypted files when using OMEMO #1375

Send and retrieve encrypted files when using OMEMO #1375

wstrm commented Jun 27, 2020

Neustradamus commented Nov 16, 2020

wstrm commented Nov 16, 2020

wstrm commented Dec 7, 2020

jubalh left a comment

jubalh Dec 7, 2020

wstrm Dec 7, 2020

jubalh commented Dec 7, 2020

jubalh left a comment

jubalh commented Dec 9, 2020

jubalh commented Dec 9, 2020

Neustradamus commented Dec 9, 2020

Send and retrieve encrypted files when using OMEMO #1375

Send and retrieve encrypted files when using OMEMO #1375

Conversation

wstrm commented Jun 27, 2020

Neustradamus commented Nov 16, 2020

wstrm commented Nov 16, 2020

wstrm commented Dec 7, 2020

jubalh left a comment

Choose a reason for hiding this comment

jubalh Dec 7, 2020

Choose a reason for hiding this comment

wstrm Dec 7, 2020

Choose a reason for hiding this comment

jubalh commented Dec 7, 2020

jubalh left a comment

Choose a reason for hiding this comment

jubalh commented Dec 9, 2020

jubalh commented Dec 9, 2020

Neustradamus commented Dec 9, 2020