Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omemo media sharing related polishing #1447

Merged
merged 3 commits into from
Dec 9, 2020
Merged

omemo media sharing related polishing #1447

merged 3 commits into from
Dec 9, 2020

Conversation

jubalh
Copy link
Member

@jubalh jubalh commented Dec 9, 2020

No description provided.

@jubalh
Expand ~ in unique_filename_from_url()
a2291b3 
unique_filename_from_url() is used for `/url save`.
It doesn't recognize ~ by itself, we need to expand it first.

Mentioned in
#1375 (review)
@jubalh
Use get_expanded_path() in cmd_senfile()
55f09b6
@jubalh
Purge omemo sendfile from config
5179b25 
#1375 added omemo media sharing support.

Thus the protection
(#1270) to sending files plainly in an omemo chat isn't
needed anymore and got removed.

Lets clean it from the config file.
@jubalh jubalh added this to the 0.10.0 milestone Dec 9, 2020
@jubalh jubalh requested a review from wstrm December 9, 2020 07:46
@jubalh jubalh self-assigned this Dec 9, 2020
@jubalh jubalh mentioned this pull request Dec 9, 2020
Merged
@jubalh jubalh merged commit f10edd2 into master Dec 9, 2020
@jubalh jubalh deleted the omemomediasharing-impr branch June 30, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wstrm wstrm wstrm approved these changes

Assignees

@jubalh jubalh

Labels
cleanup improvement
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jubalh @wstrm