Check sender for LMC messages #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubalh
reviewed
Oct 17, 2023
src/database.c
Outdated
| @@ -395,7 +405,35 @@ _add_to_db(ProfMessage* message, char* type, const Jid* const from_jid, const Ji | |||
| if (!type) { | |||
| type = (char*)_get_message_type_str(message->type); | |||
| } | |||
|
|
|||
| // Check last-message-correction validity | |||
There was a problem hiding this comment.
This should be "LMC" and/or mention XEP name. Because we use it like this everywhere in the code and then we can grep for this string more easily.
jubalh
reviewed
Oct 17, 2023
When we received a message correction via `XEP-0308: Last Message Correction` we accepted the change without checking the sender making it possible for anybody to replace the message if the ID was known. This change has been proposed by @jubalh profanity-im#1893 (comment)
H3rnand3zzz
force-pushed
the
fix/message-replacement-verificiation
branch
from
7423ffe
to
24d0030
Compare
|
Thanks for this fix! |
thank you for quick review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message