Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Allow group milestones to be used in issues #698

Closed
zemzale opened this issue Apr 30, 2021 · 4 comments · Fixed by #824
Closed

Allow group milestones to be used in issues #698

zemzale opened this issue Apr 30, 2021 · 4 comments · Fixed by #824
Labels
cmd: issue Related to issues management enhancement New feature or request good first issue Good for newcomers priority: medium Affects more than a few users but doesn't prevent core functions status: open-for-PRs Pull request can be opened for this issue

Comments

@zemzale
Copy link
Collaborator

zemzale commented Apr 30, 2021

Describe the feature or problem you'd like to solve

When creating issue using the glab issue create command and when selecting to add metadata in the interactive mode, group milestones are not showed.

▶ glab issue create
? Choose a template feature
? Title Something
? Description <Received>
? What's next? Add metadata
? Which metadata types to add? labels, milestones
? Select Labels To do
There are no active milestones in this project
? What's next? Submit

Propose a Solution

Fetch both project and group milestones when creating issues.

Additional context

These both APIs are separate, so we can probably fetch them concurrently and merge the data for that little bit of extra perfomance.
https://docs.gitlab.com/ee/api/milestones.html
https://docs.gitlab.com/ee/api/group_milestones.html

@zemzale zemzale added enhancement New feature or request cmd: issue Related to issues management good first issue Good for newcomers priority: medium Affects more than a few users but doesn't prevent core functions status: open-for-PRs Pull request can be opened for this issue labels Apr 30, 2021
@clemsbot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had recent activity. We haven't had the time to address it yet, but we want to keep it open. This message is just a reminder for us to help triage issues.

@clemsbot clemsbot added the stale label May 31, 2021
@Hydragyrum
Copy link

It looks as though the issue is in the github.com/xanzy/go-gitlab package

@Hydragyrum
Copy link

Strike my last, it's implemented there

@clemsbot clemsbot removed the stale label Jul 6, 2021
@clemsbot
Copy link
Collaborator

clemsbot commented Aug 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. We haven't had the time to address it yet, but we want to keep it open. This message is just a reminder for us to help triage issues.

@clemsbot clemsbot added the stale label Aug 6, 2021
zemzale added a commit to zemzale/glab that referenced this issue Aug 14, 2021
When creating issues we prompted only project milestones. This would
break workflows where group milestones were used.

Issue profclems#698
zemzale added a commit to zemzale/glab that referenced this issue Aug 14, 2021
When creating issues we prompted only project milestones. This would
break workflows where group milestones were used.

They are two different APIs so we have to normalize their output and
merge it to one.

Issue profclems#698
@profclems profclems removed the stale label Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cmd: issue Related to issues management enhancement New feature or request good first issue Good for newcomers priority: medium Affects more than a few users but doesn't prevent core functions status: open-for-PRs Pull request can be opened for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants