This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
feat(cmdutils): Add project and group milestone prompt #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemzale
changed the title
When creating issues we prompted only project milestones. This would break workflows where group milestones were used. They are two different APIs so we have to normalize their output and merge it to one. Issue profclems#698
zemzale
force-pushed
the
feat-all-milestones
branch
from
4af30b2
to
0cf8e61
Compare
Codecov Report
@@ Coverage Diff @@
## trunk #824 +/- ##
=======================================
Coverage 59.29% 59.30%
=======================================
Files 93 93
Lines 7353 7354 +1
=======================================
+ Hits 4360 4361 +1
Misses 2613 2613
Partials 380 380
Continue to review full report at Codecov.
|
|
Sorry for the delay. This is a great feature and I want to have enough time to review it. I will review this today |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating issues we prompted only project milestones. This would break workflows where group milestones were used.
This PR adds listing of all project related milestones in the prompt. That includes group and parent group milestones. I had to somehow normalize the milestone APIs because they are two different APIs. I didn't look into if the responses are identical(lack of time) but if it's needed we can always expand the current normalized structs to have all the needed attributes.
For this, we only need the title and ID so that is all I added.
Request to the group API only happens if the project namespace is group, otherwise the API would 404 with no group found error.
I also made fetching of milestones concurrent to improve the performance a bit.
Related Issue
Resolves #698
How Has This Been Tested?
Unit tests and testing against all kinds of group user configurations on Gitlab.com
Screenshots (if appropriate):
Types of changes