Bind exchange #35
Merged
Bind exchange #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvolpe
reviewed
Jul 7, 2017
| @@ -22,7 +22,7 @@ import scala.language.higherKinds | |||
| * program.run.unsafeRunSync | |||
| * }}} | |||
| * | |||
| * Having this generic type allows the fs2-rabbit library to to this for any effect: | |||
| * Having this generic type allows the fs2-rabbit library to do this for any effect: | |||
|
Great! I'll merge it and I'll look into the qpid broker issue to see if can pick your unit test as well. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31
bindExchange test is ignored, because qpid does not support bindExchange.