create acker consumer with configurable ack-multiple flag #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustafson
reviewed
Mar 31, 2021
|
|
||
| trait Acking[F[_]] { | ||
| def createAcker(channel: AMQPChannel): F[AckResult => F[Unit]] |
There was a problem hiding this comment.
Might need to mark this as deprecated first, or are we happy making it a breaking change?
We could keep the existing method as
def createAcker(channel: AMQPChannel): F[AckResult => F[Unit]] =
createAcker(channel: AMQPChannel, AckMultiple(false))(if we allow an overloaded name)
There was a problem hiding this comment.
I think we can make it a breaking change, as this will go into the next major release. The API exposed by RabbitClient should remain source-compatible, so I'm not too worried.
agustafson
reviewed
Mar 31, 2021
agustafson
reviewed
Mar 31, 2021
core/src/main/scala/dev/profunktor/fs2rabbit/program/AckingProgram.scala
Outdated
Show resolved
Hide resolved
jbwheatley
force-pushed
the
acker-configurable-multiple-flag
branch
from
b5e1eaa
to
5e75cf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #461
adds a new function to rabbit client:
createAckerConsumerWithMultipleFlagwhich returns an acker function(AckResult, AckMultiple) => F[Unit]args as oppose tocreateAckerConsumer's return type ofAckResult => F[Unit].adds an arg to
createAckerConsumerto set the ack multiple flag for the entire lifetime of the created consumer.(sorry, scalafmt rules are on a rampage since I turned it on in my ide)