Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where headers with arrays would throw a MatchError exception. #76

Merged
merged 1 commit into from
Jul 21, 2018

Conversation

orium
Copy link
Contributor

@orium orium commented Jul 16, 2018

Apparently header values can be arrays, in which case fs2-rabbit would throw MatchError when trying to convert them to AmqpHeaderVal, which prevented it from consuming messages.

Aparently there are other types that are not supported and will cause the same error: https://www.rabbitmq.com/amqp-0-9-1-errata.html#section_3

@codecov-io
Copy link

codecov-io commented Jul 16, 2018

Codecov Report

Merging #76 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage      99%   99.02%   +0.01%     
==========================================
  Files          11       11              
  Lines         101      103       +2     
==========================================
+ Hits          100      102       +2     
  Misses          1        1
Impacted Files Coverage Δ
...main/scala/com/github/gvolpe/fs2rabbit/model.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9472f98...69a58e1. Read the comment docs.

@gvolpe
Copy link
Member

gvolpe commented Jul 21, 2018

Thanks @orium and sorry for the delay in getting back to you, I'm just back from my holidays.

Unfortunately the headers stuff was never fully implemented.

@gvolpe gvolpe merged commit 26906b3 into profunktor:master Jul 21, 2018
@orium orium deleted the fix-header-array branch August 30, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants