Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for KEEPTTL option in SET command #714

Merged
merged 3 commits into from
Jul 23, 2022
Merged

Add support for KEEPTTL option in SET command #714

merged 3 commits into from
Jul 23, 2022

Conversation

MamdouhAhmed
Copy link
Collaborator

Hello,

This PR simply adds support for KEEPTTL option in the SET.

KeepTtl has just been added as another TTL option, in accordance with the documented SET command syntax.

Usage example:

redis.set("key", "value", SetArgs(SetArg.Ttl.KeepTtl))

gvolpe
gvolpe requested changes Jul 23, 2022
View reviewed changes
Copy link
Member

@gvolpe gvolpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Suggested a simple change but other than that looks great.

modules/effects/src/main/scala/dev/profunktor/redis4cats/redis.scala Outdated Show resolved Hide resolved
@gvolpe gvolpe enabled auto-merge (squash) July 23, 2022 11:07
@gvolpe gvolpe merged commit 65978dc into profunktor:series/1.x Jul 23, 2022
@gvolpe gvolpe mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvolpe gvolpe gvolpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MamdouhAhmed @gvolpe