Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mima version plugin #870

Merged
merged 3 commits into from
May 10, 2024
Merged

add mima version plugin #870

merged 3 commits into from
May 10, 2024

Conversation

yisraelU
Copy link
Collaborator

@yisraelU yisraelU commented May 9, 2024 •
edited
Loading

This PR

  • introduces the Mima plugin and provides a wrapper with some sane defaults
  • sets the current version to 1.7.0
  • adds to the buildredis4cats sbt alias the mimaReportBinaryIssuesIfRelevant sbt command

@yisraelU yisraelU requested a review from gvolpe May 9, 2024 20:04
gvolpe
gvolpe reviewed May 10, 2024
View reviewed changes
Copy link
Member

@gvolpe gvolpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

Does mimaReportBinaryIssuesIfRelevant fail the build when issues are found?

project/MimaVersionPlugin.scala Outdated Show resolved Hide resolved
@yisraelU
Copy link
Collaborator Author

LGTM 👍🏽

Does mimaReportBinaryIssuesIfRelevant fail the build when issues are found?

yes

@yisraelU yisraelU merged commit 29c5099 into profunktor:series/1.x May 10, 2024
2 checks passed
@yisraelU yisraelU deleted the Mima branch May 10, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvolpe gvolpe gvolpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yisraelU @gvolpe