Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unnecessary option wrapping #873

Merged
merged 3 commits into from
May 17, 2024

Conversation

yisraelU
Copy link
Collaborator

fixes #854

The commands modified in this PR do not return null as part of the underlying lettuce API , which would be the only reason to just wrap in an Option

@yisraelU yisraelU marked this pull request as draft May 15, 2024 20:08
@yisraelU yisraelU marked this pull request as ready for review May 17, 2024 15:22
@yisraelU yisraelU merged commit b760f1a into profunktor:series/1.x May 17, 2024
2 checks passed
@yisraelU yisraelU deleted the Len-Fxns branch May 17, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xLEN-like commands have either incorrect or misleading return value types
2 participants