Ci workflow #115
Merged
Ci workflow #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 146
💛 - Coveralls |
barbieri
force-pushed
the
ci-workflow
branch
6 times, most recently
from
8b285bc
to
f24e00e
Compare
Ignore on the @Property line is not enough
Python did change the repr() since then and it was failing, relax the test a little bit by using more ellipsis
Until 3.7 this worked, but since 3.8 it's failing since `ValueError`
(caused in the scalar selection dir()) wasn't caught:
Failed example:
for name in dir(repository.issues.number()): # no fields for scalar
if not name.startswith('_'):
print(name)
Exception raised:
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.9.0/x64/lib/python3.9/doctest.py", line 1336, in __run
exec(compile(example.source, filename, "single",
File "<doctest sgqlc.operation[138]>", line 1, in <module>
for name in dir(repository.issues.number()): # no fields for scalar
File "/home/runner/work/sgqlc/sgqlc/sgqlc/operation/__init__.py", line 1285, in __dir__
original_dir = super(Selection, self).__dir__()
File "/home/runner/work/sgqlc/sgqlc/sgqlc/operation/__init__.py", line 1302, in __getattr__
return self[name]
File "/home/runner/work/sgqlc/sgqlc/sgqlc/operation/__init__.py", line 1308, in __getitem__
raise ValueError('Field %r of %s is not a container type.' %
ValueError: Field number: Int! of Issue is not a container type.
barbieri
force-pushed
the
ci-workflow
branch
from
f24e00e
to
cf677a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.