Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci workflow #115

Merged
merged 6 commits into from
Dec 15, 2020
Merged

Ci workflow #115

merged 6 commits into from
Dec 15, 2020

Commits on Dec 15, 2020

  1. we're not covering codegen with tests (yet)

    @barbieri
    barbieri committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    7634853 View commit details
    Browse the repository at this point in the history

  2. ignore A003 (required in Python>3.7) 

    Ignore on the @Property line is not enough
    @barbieri
    barbieri committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    7125f32 View commit details
    Browse the repository at this point in the history

  3. fix sphinx warning (missing reference)

    @barbieri
    barbieri committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    6099f0c View commit details
    Browse the repository at this point in the history

  4. make doctest for tzinfo work with python 3.6 

    Python did change the repr() since then and it was failing, relax the
test a little bit by using more ellipsis
    @barbieri
    barbieri committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    a5affea View commit details
    Browse the repository at this point in the history

  5. __getattr__ should only fail silently with AttributeError 

    Until 3.7 this worked, but since 3.8 it's failing since `ValueError`
(caused in the scalar selection dir()) wasn't caught:

Failed example:
    for name in dir(repository.issues.number()): # no fields for scalar
        if not name.startswith('_'):
            print(name)
Exception raised:
    Traceback (most recent call last):
      File "/opt/hostedtoolcache/Python/3.9.0/x64/lib/python3.9/doctest.py", line 1336, in __run
        exec(compile(example.source, filename, "single",
      File "<doctest sgqlc.operation[138]>", line 1, in <module>
        for name in dir(repository.issues.number()): # no fields for scalar
      File "/home/runner/work/sgqlc/sgqlc/sgqlc/operation/__init__.py", line 1285, in __dir__
        original_dir = super(Selection, self).__dir__()
      File "/home/runner/work/sgqlc/sgqlc/sgqlc/operation/__init__.py", line 1302, in __getattr__
        return self[name]
      File "/home/runner/work/sgqlc/sgqlc/sgqlc/operation/__init__.py", line 1308, in __getitem__
        raise ValueError('Field %r of %s is not a container type.' %
    ValueError: Field number: Int! of Issue is not a container type.
    @barbieri
    barbieri committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    4ab6430 View commit details
    Browse the repository at this point in the history

  6. add GitHub Actions CI with multiple Python versions

    @barbieri
    barbieri committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    cf677a5 View commit details
    Browse the repository at this point in the history