Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag the image on Docker index #3

Closed
fgrehm opened this issue May 29, 2014 · 12 comments
Closed

Tag the image on Docker index #3

fgrehm opened this issue May 29, 2014 · 12 comments

Comments

@fgrehm
Copy link

fgrehm commented May 29, 2014

Hey there,

I'm currently using cedarish as the base image for one of my images and because the only tag available right now is latest it is pretty hard to have 100% reproducible builds since things might change when new cedarish images get built.

Would it be possible for you to create a tag? I don't need anything fancy, something like a timestamp of the build date would do the trick :-)

Thanks in advance!

@bacongobbler
Copy link
Collaborator

That sounds do-able. How do the following tags sound for the respective stacks?

cedar
cedar-14

FYI there seems to be some development ongoing upstream for Docker integration on Heroku's stack images: heroku/base-images@40d01e2

@fgrehm
Copy link
Author

fgrehm commented Aug 21, 2014

Yeah, I think those tags would be nice :)

@bacongobbler
Copy link
Collaborator

The underlying issue here is that we're playing catch-up with Heroku. That sometimes means that we're not exactly 1-1 with them. Every time they update the cedar14 stack, we'll be doing the same. Tagging each time we bump the images would certainly be a hassle, and by definition it means we're incompatible with their cedar stack. I understand that it's an issue with trying to make a reproducible environment, but it's also an issue with how Heroku's currently building out their new cedar stack.

In the meantime, a cedar branch would be good because that stack isn't changing any time soon.

@progrium, thoughts on this?

@progrium
Copy link
Owner

I don't think we should tag each bump. It seems like we had come up with a good idea to have a cedar and cedar14 branch and have Docker Hub keep tags based on each, but not for any minor revisions.

@bacongobbler
Copy link
Collaborator

the problem with tagging cedar14 is that it's in active development, which could be troublesome. cedar should be fine, though. Once the new cedar stack is more stable, I agree that we can tag it as cedar14. :)

@progrium
Copy link
Owner

I guess it's not ok to treat docker tags as branches? I thought it was.

On Wednesday, August 27, 2014, Matthew Fisher notifications@github.com
wrote:

the problem with tagging cedar14 is that it's in active development,
though, which could be troublesome. cedar should be fine, I think


Reply to this email directly or view it on GitHub
#3 (comment).

Jeff Lindsay
http://progrium.com

@bacongobbler
Copy link
Collaborator

Yes, you can treat tags as branches. Apologies for the confusion.

I've gone ahead and created cedar and cedar14 branches. The former is pointing at c3ec582 and the latter is pointing to HEAD. Could you please create new automated builds on DockerHub for these branches? Thanks :)

@progrium
Copy link
Owner

Done!

On Thu, Aug 28, 2014 at 10:20 AM, Matthew Fisher notifications@github.com
wrote:

Yes, you can treat tags as branches. Apologies for the confusion.

I've gone ahead and created cedar and cedar14 branches. The former is
pointing at c3ec582
c3ec582
and the latter is pointing to HEAD. Could you please create new automated
builds on DockerHub for these branches? Thanks :)


Reply to this email directly or view it on GitHub
#3 (comment).

Jeff Lindsay
http://progrium.com

@bacongobbler
Copy link
Collaborator

I see a cedar14 tag, but not cedar :( good to close otherwise

@progrium
Copy link
Owner

Yeah that's weird. Maybe it needs to be pushed to. I can also add you as a
collaborator with your Hub username.

On Thu, Aug 28, 2014 at 11:21 AM, Matthew Fisher notifications@github.com
wrote:

I see a cedar14 tag, but not cedar :(


Reply to this email directly or view it on GitHub
#3 (comment).

Jeff Lindsay
http://progrium.com

@bacongobbler
Copy link
Collaborator

good to close. Turns out that the quantal repository was moved to old-releases.ubuntu.com because it's now unsupported. The builds should be good to go now.

@fgrehm
Copy link
Author

fgrehm commented Sep 3, 2014

Thanks a lot guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants